Xiyuan Chen and GitHub
9e74520b50
Merge branch 'main' into gareth/esq1-170-rbac-for-agent
2026-07-22 22:01:46 -07:00
GareArc
d16d2d1efa
Merge remote-tracking branch 'origin/gareth/esq1-170-rbac-for-agent' into gareth/esq1-170-rbac-for-agent
2026-07-22 21:32:30 -07:00
GareArc
91126a5fda
fix(agent): stack agent.manage onto agent app management and import paths
...
Roster composer writes keep their app_edit / snippets gate and require
workspace agent.manage in addition, instead of replacing it. Generic app
management routes (update/delete/copy/export/name/icon/site/site-enable/
api-enable/api-keys) enforce agent.manage when the target is a roster
Agent App and reject hidden workflow-only backing apps outright, which
stay usable only through the Agent runtime surfaces. Importing an Agent
DSL requires agent.manage and the denial surfaces as 403 instead of a
generic failed import.
2026-07-22 21:31:56 -07:00
GareArc
8482167f1c
fix(agent): authorize workflow-only agents against their parent workflow app
...
The RBAC resource resolver returned the hidden runtime backing app for
workflow-only agents, which never receives a resource access policy, so
per-resource overrides on the parent workflow app were ignored. Resolve
agent_id to the policy-owning agent.app_id instead and keep
backing_app_id strictly runtime-only.
2026-07-22 21:31:43 -07:00
yyh and GitHub
6cd10f5e04
Merge branch 'main' into gareth/esq1-170-rbac-for-agent
2026-07-23 12:07:51 +08:00
2b8e40af32
fix(auth): validate account before accepting invitations ( #39438 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-23 03:56:32 +00:00
GareArc
1b5fbb2142
Merge remote-tracking branch 'origin/main' into gareth/esq1-170-rbac-for-agent
2026-07-22 20:24:53 -07:00
0ad985515b
test: move password reset coverage to unit tests ( #38936 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-23 03:16:06 +00:00
bd8f0104d6
feat(dataset): expose New RAG KnowledgeFS contracts ( #39314 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-23 01:48:36 +00:00
34a5ca191b
feat(dataset): add New Knowledge list and empty state ( #39300 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-22 12:00:50 +00:00
Asuka Minato and GitHub
84889b88ec
test: use sqlite3 session in test_init_validate ( #38680 )
2026-07-22 09:44:29 +00:00
Asuka Minato and GitHub
6f034d2c93
test: use sqlite3 session in test_tags ( #38679 )
2026-07-22 09:43:41 +00:00
f91ea49414
test: use sqlite3 session in test_app_import_api ( #38674 )
...
Co-authored-by: Byron Wang <byron@dify.ai >
2026-07-22 09:43:30 +00:00
Asuka Minato and GitHub
de07730548
test: use sqlite3 session in test_snippet_workflow_draft_variable ( #38678 )
2026-07-22 09:20:51 +00:00
Asuka Minato and GitHub
9b2aa8b216
test: use sqlite3 session in test_snippet_workflow ( #38677 )
2026-07-22 09:20:21 +00:00
Asuka Minato and GitHub
8ee3a7eabc
test: use sqlite3 session in test_rag_pipeline_workflow ( #38676 )
2026-07-22 09:19:25 +00:00
0f9fffb7a2
fix(agent): isolate build and preview chat conversations ( #39405 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-22 09:17:55 +00:00
林玮 (Jade Lin) and GitHub
a3654d6a7d
fix(oauth): reauth after accepting invitation ( #39366 )
2026-07-22 05:59:04 +00:00
Asuka Minato and GitHub
c5d471dbdd
test: use sqlite3 session in test_model_config_api ( #38675 )
2026-07-22 04:53:13 +00:00
Asuka Minato and GitHub
7b95e2a75f
test: use sqlite3 session in test_generator_api_missing ( #38719 )
2026-07-22 04:52:06 +00:00
Asuka Minato and GitHub
79a5b31bc6
test: move console OAuth coverage to unit tests ( #38923 )
2026-07-22 02:27:55 +00:00
GareArc
ac87341d69
Merge remote-tracking branch 'origin/main' into gareth/esq1-170-rbac-for-agent
...
# Conflicts:
# api/services/enterprise/rbac_service.py
2026-07-21 03:02:11 -07:00
GareArc
75cb8ea408
refactor(api): reuse the roster service's agent resolution for RBAC checks
...
The app-scoped RBAC gate hand-rolled a query to turn an agent_id into the id
of the App backing it, duplicating AgentRosterService.runtime_backing_app_id.
Worse, it filtered on id and tenant only, so the auth check accepted archived
Agents and sources the runtime resolver rejects -- a weaker notion of a valid
Agent than the layer it guards.
Add peek_runtime_backing_app_id, a read-only counterpart to
get_agent_runtime_app_model that never materializes the hidden backing App,
and share the eligibility filter between the two so they cannot drift.
The tenant filter was also untested: deleting it left all 50 tests passing,
since the specs stubbed the db module wholesale. Assert the resolver is called
with the caller's tenant instead, and cover the precedence and read-only
guarantees against the service directly.
2026-07-21 01:34:16 -07:00
Asuka Minato and GitHub
145b0e622e
test: use sqlite3 session in test_workspace_account ( #38757 )
2026-07-21 08:07:57 +00:00
Asuka Minato and GitHub
32d2594877
test: move app import API coverage to unit tests ( #38920 )
2026-07-21 07:54:32 +00:00
Asuka Minato and GitHub
7b188287da
test: use sqlite3 session in test_accounts ( #38752 )
2026-07-21 07:50:05 +00:00
Asuka Minato and GitHub
852169d99c
test: use SQLite sessions in unit misc ( #39118 )
2026-07-21 07:27:13 +00:00
GareArc
edbaaeae23
fix(api): resolve agent routes to their backing app for app-scoped RBAC
2026-07-21 00:22:24 -07:00
aa718add24
fix(api): return 400 instead of 500 when 'file' is missing from trial-app audio-to-text ( #39305 )
...
Co-authored-by: Harsh Kashyap <Harsh23Kashyap@users.noreply.github.com >
2026-07-21 05:59:48 +00:00
yyh and GitHub
861831f176
fix(api): keep workflow log archives owner-admin only ( #39338 )
2026-07-21 04:31:14 +00:00
cbd7872520
test: use SQLite sessions in unit misc ( #39121 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-20 10:38:52 +00:00
23882a704e
test: use SQLite sessions in unit misc ( #39122 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-20 10:38:49 +00:00
1bd5254ea7
test: use SQLite sessions in unit misc ( #39123 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-20 10:38:46 +00:00
cb64446fa3
feat(web): add step-by-step tour shell ( #38785 )
...
Co-authored-by: hjlarry <hjlarry@163.com >
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: yyh <yuanyouhuilyz@gmail.com >
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com >
2026-07-20 09:23:25 +00:00
43d725a1ce
feat(dataset): proxy KnowledgeFS Console requests ( #39158 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-20 08:10:06 +00:00
f93a5b95c6
fix(api, web): scope trial app file uploads to the app tenant ( #39149 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-20 07:00:45 +00:00
6022939bf0
fix: prevent hidden-tab collaboration leader from saving stale drafts ( #38997 )
...
Co-authored-by: hjlarry <hjlarry@163.com >
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: yyh <yuanyouhuilyz@gmail.com >
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com >
2026-07-20 06:58:01 +00:00
Asuka Minato and GitHub
415c0db22e
test: use sqlite3 session in test_tool_providers ( #38754 )
2026-07-16 12:28:26 +00:00
cb41fb3e76
fix(api): serialize trial workflow conversation variables ( #39038 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-16 02:57:06 +00:00
73c3048599
fix(agent): preserve DSL asset placeholders and count draft references ( #39015 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-15 11:49:11 +00:00
WH-2099 and GitHub
6a511da325
fix(api): bind scoped lookups to nested owner refs ( #38470 )
2026-07-15 09:31:09 +00:00
Xin Zhang and GitHub
120c38bad8
feat(enterprise): reject member invites that would exceed licensed seats ( #38995 )
2026-07-15 07:59:16 +00:00
ab3e4daa95
refactor: explicit DB session propagation across backend paths ( #38559 )
...
Co-authored-by: WH-2099 <wh2099@pm.me >
2026-07-15 06:48:28 +00:00
林玮 (Jade Lin) and GitHub
edca982b1e
fix(api): harden trial apps access for recommended apps ( #38970 )
2026-07-15 06:04:07 +00:00
fbd6e04810
test: move console app API coverage to unit tests ( #38915 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-15 04:40:15 +00:00
c277f48084
test: move email registration coverage to unit tests ( #38928 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-15 04:05:59 +00:00
70462d96bd
test: move RAG pipeline controller coverage to unit tests ( #38939 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-15 03:59:57 +00:00
Asuka Minato and GitHub
22429d275a
test: move console forgot-password coverage to unit tests ( #38922 )
2026-07-15 03:56:41 +00:00
Asuka Minato and GitHub
571e50175e
test: move RAG pipeline dataset coverage to unit tests ( #38933 )
2026-07-15 03:26:34 +00:00
a4b64d1fd7
test: move tool provider controller coverage to unit tests ( #38944 )
...
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-07-15 03:12:43 +00:00
